Messages in this thread | | | Date | Mon, 23 Sep 2019 15:34:22 +0200 | From | Paul Kocialkowski <> | Subject | Re: [PATCH 1/3] gpio: syscon: Add support for a custom get operation |
| |
Hi,
On Thu 12 Sep 19, 10:18, Linus Walleij wrote: > On Tue, Sep 10, 2019 at 4:29 PM Paul Kocialkowski > <paul.kocialkowski@bootlin.com> wrote: > > > Some drivers might need a custom get operation to match custom > > behavior implemented in the set operation. > > > > Add plumbing for supporting that. > > > > Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com> > > Looks OK but as noted in the other patch: we are accumulating stuff > in this driver, possibly this syscon part should just be a library > used by individual drivers that can be switched on/off with Kconfig.
Looks like adding support for a custom get operation would be good to have before moving to a library then :)
Cheers,
Paul
-- Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com [unhandled content-type:application/pgp-signature] | |