Messages in this thread | | | Subject | Re: [PATCH v2 04/11] drm/shmem: drop VM_IO | From | Steven Price <> | Date | Mon, 23 Sep 2019 14:32:55 +0100 |
| |
On 17/09/2019 10:23, Gerd Hoffmann wrote: > VM_IO is wrong here, shmem uses normal ram not io memory. > > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Steven Price <steven.price@arm.com>
> --- > drivers/gpu/drm/drm_gem_shmem_helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c > index 6efedab15016..3bc69b1ffa7d 100644 > --- a/drivers/gpu/drm/drm_gem_shmem_helper.c > +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c > @@ -536,7 +536,7 @@ int drm_gem_shmem_mmap(struct drm_gem_object *obj, struct vm_area_struct *vma) > return ret; > } > > - vma->vm_flags |= VM_IO | VM_MIXEDMAP | VM_DONTEXPAND; > + vma->vm_flags |= VM_MIXEDMAP | VM_DONTEXPAND; > vma->vm_page_prot = pgprot_writecombine(vm_get_page_prot(vma->vm_flags)); > vma->vm_page_prot = pgprot_decrypted(vma->vm_page_prot); > vma->vm_ops = &drm_gem_shmem_vm_ops; >
| |