lkml.org 
[lkml]   [2019]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] dimlib: make DIMLIB a hidden symbol
From
Date
Hello Jakub,

On 9/22/19 5:06 AM, Jakub Kicinski wrote:
> On Fri, 20 Sep 2019 15:31:15 +0200, Uwe Kleine-König wrote:
>> According to Tal Gilboa the only benefit from DIM comes from a driver
>> that uses it. So it doesn't make sense to make this symbol user visible,
>> instead all drivers that use it should select it (as is already the case
>> AFAICT).
>>
>> Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
>> ---
>> lib/Kconfig | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/lib/Kconfig b/lib/Kconfig
>> index cc04124ed8f7..9fe8a21fd183 100644
>> --- a/lib/Kconfig
>> +++ b/lib/Kconfig
>> @@ -555,8 +555,7 @@ config SIGNATURE
>> Implementation is done using GnuPG MPI library
>>
>> config DIMLIB
>> - bool "DIM library"
>> - default y
>> + bool
>> help
>> Dynamic Interrupt Moderation library.
>> Implements an algorithm for dynamically change CQ moderation values
>
> Hi Uwe! Looks like in the net tree there is a spelling mistake and
> moderation is spelled "modertion":
>
> https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/tree/lib/Kconfig#n562
>
> I'm not seeing any patch to fix that anywhere, is it possible you have
> some local change in your tree?

I sent a patch[1] for that typo, but at that time wasn't aware that
DIMLIB was relevant for net and so didn't Cc the netdev.

Best regards
Uwe

[1]
https://lore.kernel.org/lkml/20190919210314.22110-1-uwe@kleine-koenig.org/

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2019-09-23 08:18    [W:0.085 / U:0.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site