Messages in this thread | | | Subject | Re: [PATCH v2] erofs: fix erofs_get_meta_page locking by a cleanup | From | Chao Yu <> | Date | Mon, 23 Sep 2019 20:16:57 +0800 |
| |
On 2019/9/22 2:43, Gao Xiang wrote: > After doing more drop_caches stress test on > our products, I found the mistake introduced by > a very recent cleanup [1]. > > The current rule is that "erofs_get_meta_page" > should be returned with page locked (although > it's mostly unnecessary for read-only fs after > pages are PG_uptodate), but a fix should be > done for this. > > [1] https://lore.kernel.org/r/20190904020912.63925-26-gaoxiang25@huawei.com > Fixes: 618f40ea026b ("erofs: use read_cache_page_gfp for erofs_get_meta_page") > Signed-off-by: Gao Xiang <gaoxiang25@huawei.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Thanks,
| |