lkml.org 
[lkml]   [2019]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V8 2/2] arm64/mm: Enable memory hot remove
On Mon, Sep 23, 2019 at 11:13:45AM +0530, Anshuman Khandual wrote:
> +#ifdef CONFIG_MEMORY_HOTPLUG
> +static void free_hotplug_page_range(struct page *page, size_t size)
> +{
> + WARN_ON(!page || PageReserved(page));

WARN_ON(!page) isn't terribly useful. You're going to crash on the very
next line when you call page_address() anyway. If this line were

if (WARN_ON(!page || PageReserved(page)))
return;

it would make sense, or if it were just

WARN_ON(PageReserved(page))

it would also make sense.

> + free_pages((unsigned long)page_address(page), get_order(size));
> +}

\
 
 \ /
  Last update: 2019-09-23 13:18    [W:0.093 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site