Messages in this thread | | | Date | Mon, 23 Sep 2019 12:27:56 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH RESEND] gen-insn-attr-x86.awk: Fix regexp warnings |
| |
On Mon, Sep 23, 2019 at 12:56:14PM +0300, Alexander Kapshuk wrote: > On Mon, Sep 23, 2019 at 12:19 PM Borislav Petkov <bp@alien8.de> wrote: > > > > On Sun, Sep 22, 2019 at 06:03:28PM +0300, Alexander Kapshuk wrote: > > > This patch fixes the regexp warnings shown below: > > > GEN /home/sasha/torvalds/tools/objtool/arch/x86/lib/inat-tables.c > > > awk: ../arch/x86/tools/gen-insn-attr-x86.awk:260: warning: regexp escape sequence `\:' is not a known regexp operator > > > awk: ../arch/x86/tools/gen-insn-attr-x86.awk:350: (FILENAME=../arch/x86/lib/x86-opcode-map.txt FNR=41) warning: regexp escape sequence `\&' is not a known regexp operator > > > > > > The ':' and '&' characters need not escaping when used in string constants > > > as part of regular expressions. > > > > How do you trigger this? > > > > I don't see it in my builds so it looks like environment thing. What > > flavor of awk is yours? > > > > Thx. > > > > -- > > Regards/Gruss, > > Boris. > > > > https://people.kernel.org/tglx/notes-about-netiquette > > gawk 5.0.1-1 on Arch Linux.
Ok, looks like they're enforcing it in v5 as v4 which I have doesn't complain. Please add that fact to the commit message.
More review as a reply to your second patch.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |