| Subject | Re: [PATCH 13/17] KVM: monolithic: x86: drop the kvm_pmu_ops structure | From | Paolo Bonzini <> | Date | Mon, 23 Sep 2019 12:21:43 +0200 |
| |
On 20/09/19 23:25, Andrea Arcangeli wrote: > Cleanup after this was finally left fully unused. > > Signed-off-by: Andrea Arcangeli <aarcange@redhat.com> > --- > arch/x86/include/asm/kvm_host.h | 3 --- > arch/x86/kvm/pmu.h | 19 ------------------- > arch/x86/kvm/pmu_amd.c | 15 --------------- > arch/x86/kvm/svm.c | 1 - > arch/x86/kvm/vmx/pmu_intel.c | 15 --------------- > arch/x86/kvm/vmx/vmx.c | 2 -- > 6 files changed, 55 deletions(-)
Is there any reason not to do the same for kvm_x86_ops?
(As an aside, patch 2 is not copying over the comments in the struct kvm_x86_ops declarations. Granted there aren't many, but we should not lose the few that exist).
Paolo
|