Messages in this thread | | | Date | Fri, 20 Sep 2019 14:08:33 -0700 | From | Tejun Heo <> | Subject | Re: [PATCH] workqueue: Fix spurious sanity check failures in destroy_workqueue() |
| |
Hello,
On Thu, Sep 19, 2019 at 10:49:04AM +0800, Lai Jiangshan wrote: > Looks good to me. > > There is one test in show_pwq() > """ > worker == pwq->wq->rescuer ? "(RESCUER)" : "", > """ > I'm wondering if it needs to be updated to > """ > worker->rescue_wq ? "(RESCUER)" : "", > """
Hmm... yeah, good point. Let's do that.
> And document "/* MD: rescue worker */" might be better > than current "/* I: rescue worker */", although ->rescuer can > be accessed without wq_mayday_lock lock in some code.
Will apply this one too.
Thanks.
-- tejun
| |