Messages in this thread | | | Date | Fri, 20 Sep 2019 18:11:41 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH] dt-bindings: net: dwmac: fix 'mac-mode' type |
| |
On Tue, 17 Sep 2019 13:30:52 +0300, Alexandru Ardelean wrote: > The 'mac-mode' property is similar to 'phy-mode' and 'phy-connection-type', > which are enums of mode strings. > > The 'dwmac' driver supports almost all modes declared in the 'phy-mode' > enum (except for 1 or 2). But in general, there may be a case where > 'mac-mode' becomes more generic and is moved as part of phylib or netdev. > > In any case, the 'mac-mode' field should be made an enum, and it also makes > sense to just reference the 'phy-connection-type' from > 'ethernet-controller.yaml'. That will also make it more future-proof for new > modes. > > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Applied, thank you!
FWIW I had to add the Fixes tag by hand, either ozlabs patchwork or my git-pw doesn't have the automagic handling there, yet.
| |