Messages in this thread | | | Date | Sat, 21 Sep 2019 02:12:28 +0300 | From | Laurent Pinchart <> | Subject | Re: [PATCH 06/11] drm/bridge: ti-tfp410: switch to using fwnode_gpiod_get_index() |
| |
Hi Dmitry,
(CC'ing Heikki as the original author of software nodes support)
Thank you for the patch.
On Wed, Sep 11, 2019 at 12:52:10AM -0700, Dmitry Torokhov wrote: > Instead of fwnode_get_named_gpiod() that I plan to hide away, let's use > the new fwnode_gpiod_get_index() that mimics gpiod_get_index(), bit
s/bit/but/
> works with arbitrary firmware node. > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
On a side note, as I'm not very familiar with software nodes, I tried to see how they are to be used, and it seems they are completely undocumented :-( Heikki, is this something that could be fixed ?
> --- > > drivers/gpu/drm/bridge/ti-tfp410.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c > index 61cc2354ef1b..d9c9c9ebad2b 100644 > --- a/drivers/gpu/drm/bridge/ti-tfp410.c > +++ b/drivers/gpu/drm/bridge/ti-tfp410.c > @@ -284,8 +284,8 @@ static int tfp410_get_connector_properties(struct tfp410 *dvi) > else > dvi->connector_type = DRM_MODE_CONNECTOR_DVID; > > - dvi->hpd = fwnode_get_named_gpiod(&connector_node->fwnode, > - "hpd-gpios", 0, GPIOD_IN, "hpd"); > + dvi->hpd = fwnode_gpiod_get_index(&connector_node->fwnode, > + "hpd", 0, GPIOD_IN, "hpd"); > if (IS_ERR(dvi->hpd)) { > ret = PTR_ERR(dvi->hpd); > dvi->hpd = NULL;
-- Regards,
Laurent Pinchart
| |