lkml.org 
[lkml]   [2019]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.2 097/124] tools/power turbostat: fix file descriptor leaks
    Date
    From: Gustavo A. R. Silva <gustavo@embeddedor.com>

    [ Upstream commit 605736c6929d541c78a85dffae4d33a23b6b2149 ]

    Fix file descriptor leaks by closing fp before return.

    Addresses-Coverity-ID: 1444591 ("Resource leak")
    Addresses-Coverity-ID: 1444592 ("Resource leak")
    Fixes: 5ea7647b333f ("tools/power turbostat: Warn on bad ACPI LPIT data")
    Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
    Reviewed-by: Prarit Bhargava <prarit@redhat.com>
    Signed-off-by: Len Brown <len.brown@intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    tools/power/x86/turbostat/turbostat.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/tools/power/x86/turbostat/turbostat.c b/tools/power/x86/turbostat/turbostat.c
    index efc8d07364c61..0ffbbcac4d19d 100644
    --- a/tools/power/x86/turbostat/turbostat.c
    +++ b/tools/power/x86/turbostat/turbostat.c
    @@ -2912,6 +2912,7 @@ int snapshot_cpu_lpi_us(void)
    if (retval != 1) {
    fprintf(stderr, "Disabling Low Power Idle CPU output\n");
    BIC_NOT_PRESENT(BIC_CPU_LPI);
    + fclose(fp);
    return -1;
    }

    --
    2.20.1


    \
     
     \ /
      Last update: 2019-09-20 00:10    [W:4.061 / U:25.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site