Messages in this thread | | | From | Dexuan Cui <> | Subject | RE: [PATCH] Drivers: hv: vmbus: Fix harmless building warnings without CONFIG_PM | Date | Thu, 19 Sep 2019 21:38:41 +0000 |
| |
> Sent: Thursday, September 19, 2019 5:11 AM > On Thu, Sep 19, 2019 at 7:19 AM Dexuan Cui <decui@microsoft.com> wrote: > > > > If CONFIG_PM is not set, we can comment out these functions to avoid the > > below warnings: > > > > drivers/hv/vmbus_drv.c:2208:12: warning: ‘vmbus_bus_resume’ defined > but not used [-Wunused-function] > > drivers/hv/vmbus_drv.c:2128:12: warning: ‘vmbus_bus_suspend’ defined > but not used [-Wunused-function] > > drivers/hv/vmbus_drv.c:937:12: warning: ‘vmbus_resume’ defined but not > used [-Wunused-function] > > drivers/hv/vmbus_drv.c:918:12: warning: ‘vmbus_suspend’ defined but not > used [-Wunused-function] > > > > Fixes: 271b2224d42f ("Drivers: hv: vmbus: Implement suspend/resume for > VSC drivers for hibernation") > > Fixes: f53335e3289f ("Drivers: hv: vmbus: Suspend/resume the vmbus itself > for hibernation") > > Reported-by: Arnd Bergmann <arnd@arndb.de> > > Signed-off-by: Dexuan Cui <decui@microsoft.com> > > I think this will still produce a warning if CONFIG_PM is set but > CONFIG_PM_SLEEP is not, possibly in other configurations as > well. > > Arnd
You're correct. Thanks!
I'll use " #ifdef CONFIG_PM_SLEEP ... #endif" instead.
The mentioned functions are only used in the micros SET_NOIRQ_SYSTEM_SLEEP_PM_OPS, which is empty if CONFIG_PM_SLEEP is not defined. So it looks to me using "#ifdef CONFIG_PM_SLEEP ..." should resolve the issue.
BTW, CONFIG_PM_SLEEP depends on CONFIG_PM, so if CONFIG_PM is not defined, CONFIG_PM_SLEEP is not defined either.
Thanks, -- Dexuan
| |