lkml.org 
[lkml]   [2019]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 3/3] dmaengine: imx-sdma: drop redundant variable
    Date
    In sdma_prep_dma_cyclic buf is redundant. Drop it.

    Signed-off-by: Philipp Puschmann <philipp.puschmann@emlix.com>
    Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
    ---

    Changelog v3,v4:
    - no changes

    Changelog v2:
    - add Reviewed-by tag

    drivers/dma/imx-sdma.c | 7 ++-----
    1 file changed, 2 insertions(+), 5 deletions(-)

    diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
    index a32b5962630e..17961451941a 100644
    --- a/drivers/dma/imx-sdma.c
    +++ b/drivers/dma/imx-sdma.c
    @@ -1544,7 +1544,7 @@ static struct dma_async_tx_descriptor *sdma_prep_dma_cyclic(
    struct sdma_engine *sdma = sdmac->sdma;
    int num_periods = buf_len / period_len;
    int channel = sdmac->channel;
    - int i = 0, buf = 0;
    + int i;
    struct sdma_desc *desc;

    dev_dbg(sdma->dev, "%s channel: %d\n", __func__, channel);
    @@ -1565,7 +1565,7 @@ static struct dma_async_tx_descriptor *sdma_prep_dma_cyclic(
    goto err_bd_out;
    }

    - while (buf < buf_len) {
    + for (i = 0; i < num_periods; i++) {
    struct sdma_buffer_descriptor *bd = &desc->bd[i];
    int param;

    @@ -1592,9 +1592,6 @@ static struct dma_async_tx_descriptor *sdma_prep_dma_cyclic(
    bd->mode.status = param;

    dma_addr += period_len;
    - buf += period_len;
    -
    - i++;
    }

    return vchan_tx_prep(&sdmac->vc, &desc->vd, flags);
    --
    2.23.0
    \
     
     \ /
      Last update: 2019-09-19 16:30    [W:2.091 / U:0.604 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site