Messages in this thread | | | From | Robert Richter <> | Subject | Re: [PATCH v2 1/2] edac: Add an API for edac device to report for multiple errors | Date | Thu, 19 Sep 2019 06:33:42 +0000 |
| |
On 12.09.19 15:53:04, Hanna Hawa wrote: > Add an API for EDAC device to report multiple errors with same type. > > Signed-off-by: Hanna Hawa <hhhawa@amazon.com> > --- > drivers/edac/edac_device.c | 91 ++++++++++++++++++++++++++++++++++++++ > drivers/edac/edac_device.h | 40 +++++++++++++++++ > 2 files changed, 131 insertions(+) > > diff --git a/drivers/edac/edac_device.c b/drivers/edac/edac_device.c > index 65cf2b9355c4..78ac44103acc 100644 > --- a/drivers/edac/edac_device.c > +++ b/drivers/edac/edac_device.c > @@ -643,3 +643,94 @@ void edac_device_handle_ue(struct edac_device_ctl_info *edac_dev, > block ? block->name : "N/A", msg); > } > EXPORT_SYMBOL_GPL(edac_device_handle_ue); > + > +void __edac_device_handle_ce(struct edac_device_ctl_info *edac_dev, > + unsigned int count, int inst_nr, int block_nr, > + const char *msg) > +{
Please do not add a copy here, instead modify the existing function and share the code with both, old and new functions.
Thanks,
-Robert
| |