Messages in this thread | | | From | Jose Abreu <> | Subject | RE: [PATCH] [v2] net: stmmac: selftest: avoid large stack usage | Date | Thu, 19 Sep 2019 13:01:22 +0000 |
| |
From: Arnd Bergmann <arnd@arndb.de> Date: Sep/19/2019, 13:33:43 (UTC+00:00)
> Putting a struct stmmac_rss object on the stack is a bad idea, > as it exceeds the warning limit for a stack frame on 32-bit architectures: > > drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c:1221:12: error: stack frame size of 1208 bytes in function '__stmmac_test_l3filt' [-Werror,-Wframe-larger-than=] > drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c:1338:12: error: stack frame size of 1208 bytes in function '__stmmac_test_l4filt' [-Werror,-Wframe-larger-than=] > > As the object is the trivial empty case, change the called function > to accept a NULL pointer to mean the same thing and remove the > large variable in the two callers. > > Fixes: 4647e021193d ("net: stmmac: selftests: Add selftest for L3/L4 Filters") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > v2: simply configure function, based on feedback from Jose
Looks good to me. Thanks for the fix :)
Acked-by: Jose Abreu <joabreu@synopsys.com>
--- Thanks, Jose Miguel Abreu
| |