Messages in this thread | | | From | Luca Coelho <> | Date | Thu, 19 Sep 2019 14:58:35 +0300 | Subject | Re: [PATCH] iwlwifi: fix building without CONFIG_THERMAL |
| |
On Thu, 2019-09-19 at 13:55 +0200, Arnd Bergmann wrote: > The iwl_mvm_send_temp_report_ths_cmd() function is now called without > CONFIG_THERMAL, but not defined: > > ERROR: "iwl_mvm_send_temp_report_ths_cmd" [drivers/net/wireless/intel/iwlwifi/mvm/iwlmvm.ko] undefined! > > Move that function out of the #ifdef as well and change it so > that empty data gets sent even if no thermal device was > registered. > > Fixes: 242d9c8b9a93 ("iwlwifi: mvm: use FW thermal monitoring regardless of CONFIG_THERMAL") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > No idea if this does what was intended in the commit that introduced > the link failure, please see for youself.
Thanks for the fix, Arnd! We already sent a fix for this though[1] and Kalle has already queued it for v5.3.
[1] https://patchwork.kernel.org/patch/11150431/
-- Cheers, Luca.
| |