Messages in this thread | | | Subject | Re: [PATCH v3 1/3] dmaengine: imx-sdma: fix buffer ownership | From | Philipp Puschmann <> | Date | Thu, 19 Sep 2019 13:42:33 +0200 |
| |
Hi Fabio,
Am 19.09.19 um 13:37 schrieb Fabio Estevam: > Hi Philipp, > > On Thu, Sep 19, 2019 at 7:45 AM Philipp Puschmann > <philipp.puschmann@emlix.com> wrote: >> >> BD_DONE flag marks ownership of the buffer. When 1 SDMA owns the >> buffer, when 0 ARM owns it. When processing the buffers in >> sdma_update_channel_loop the ownership of the currently processed >> buffer was set to SDMA again before running the callback function of >> the buffer and while the sdma script may be running in parallel. So >> there was the possibility to get the buffer overwritten by SDMA before >> it has been processed by kernel leading to kind of random errors in the >> upper layers, e.g. bluetooth. >> >> Fixes: broken since start > > The Fixes tag requires a commit ID like this: > > Fixes: 1ec1e82f2510 ("dmaengine: Add Freescale i.MX SDMA support") > > Same applies to the other patch. > oh okay, thanks. I will fix this with v4.
Regards, Philipp
| |