Messages in this thread | | | From | Michael Ellerman <> | Subject | Re: [PATCH v2] powerpc/watchpoint: Disable watchpoint hit by larx/stcx instructions | Date | Thu, 19 Sep 2019 20:25:55 +1000 (AEST) |
| |
On Tue, 2019-09-10 at 13:15:13 UTC, Ravi Bangoria wrote: > If watchpoint exception is generated by larx/stcx instructions, the > reservation created by larx gets lost while handling exception, and > thus stcx instruction always fails. Generally these instructions are > used in a while(1) loop, for example spinlocks. And because stcx > never succeeds, it loops forever and ultimately hangs the system. > > Note that ptrace anyway works in one-shot mode and thus for ptrace > we don't change the behaviour. It's up to ptrace user to take care > of this. > > Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com> > Acked-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/bc01bdf6c5df5023272a7399962cf64f8fedc93e
cheers
| |