lkml.org 
[lkml]   [2019]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2 1/1] powerpc/pseries/hotplug-memory.c: Change rc variable to bool
    From
    Date
    Hello Michael,

    Any feedback on this patch?

    Best regards,


    On Fri, 2019-08-02 at 15:45 +0200, David Hildenbrand wrote:
    > On 02.08.19 15:39, Leonardo Bras wrote:
    > > Changes the return variable to bool (as the return value) and
    > > avoids doing a ternary operation before returning.
    > >
    > > Signed-off-by: Leonardo Bras <leonardo@linux.ibm.com>
    > > ---
    > > Changes in v2:
    > > - Restore previous and-ing logic on rc.
    > >
    > > arch/powerpc/platforms/pseries/hotplug-memory.c | 6 +++---
    > > 1 file changed, 3 insertions(+), 3 deletions(-)
    > >
    > > diff --git a/arch/powerpc/platforms/pseries/hotplug-memory.c b/arch/powerpc/platforms/pseries/hotplug-memory.c
    > > index 8e700390f3d6..c126b94d1943 100644
    > > --- a/arch/powerpc/platforms/pseries/hotplug-memory.c
    > > +++ b/arch/powerpc/platforms/pseries/hotplug-memory.c
    > > @@ -338,7 +338,7 @@ static int pseries_remove_mem_node(struct device_node *np)
    > > static bool lmb_is_removable(struct drmem_lmb *lmb)
    > > {
    > > int i, scns_per_block;
    > > - int rc = 1;
    > > + bool rc = true;
    > > unsigned long pfn, block_sz;
    > > u64 phys_addr;
    > >
    > > @@ -363,11 +363,11 @@ static bool lmb_is_removable(struct drmem_lmb *lmb)
    > > if (!pfn_present(pfn))
    > > continue;
    > >
    > > - rc &= is_mem_section_removable(pfn, PAGES_PER_SECTION);
    > > + rc = rc && is_mem_section_removable(pfn, PAGES_PER_SECTION);
    > > phys_addr += MIN_MEMORY_BLOCK_SIZE;
    > > }
    > >
    > > - return rc ? true : false;
    > > + return rc;
    > > }
    > >
    > > static int dlpar_add_lmb(struct drmem_lmb *);
    > >
    >
    > Yeah, why not
    >
    > Reviewed-by: David Hildenbrand <david@redhat.com>
    >
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2019-09-20 03:58    [W:3.793 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site