lkml.org 
[lkml]   [2019]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 54/56] floppy: fix usercopy direction
    Date
    From: Jann Horn <jannh@google.com>

    commit 52f6f9d74f31078964ca1574f7bb612da7877ac8 upstream.

    As sparse points out, these two copy_from_user() should actually be
    copy_to_user().

    Fixes: 229b53c9bf4e ("take floppy compat ioctls to sodding floppy.c")
    Cc: stable@vger.kernel.org
    Acked-by: Alexander Popov <alex.popov@linux.com>
    Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
    Signed-off-by: Jann Horn <jannh@google.com>
    Signed-off-by: Jens Axboe <axboe@kernel.dk>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/block/floppy.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/block/floppy.c
    +++ b/drivers/block/floppy.c
    @@ -3784,7 +3784,7 @@ static int compat_getdrvprm(int drive,
    v.native_format = UDP->native_format;
    mutex_unlock(&floppy_mutex);

    - if (copy_from_user(arg, &v, sizeof(struct compat_floppy_drive_params)))
    + if (copy_to_user(arg, &v, sizeof(struct compat_floppy_drive_params)))
    return -EFAULT;
    return 0;
    }
    @@ -3820,7 +3820,7 @@ static int compat_getdrvstat(int drive,
    v.bufblocks = UDRS->bufblocks;
    mutex_unlock(&floppy_mutex);

    - if (copy_from_user(arg, &v, sizeof(struct compat_floppy_drive_struct)))
    + if (copy_to_user(arg, &v, sizeof(struct compat_floppy_drive_struct)))
    return -EFAULT;
    return 0;
    Eintr:

    \
     
     \ /
      Last update: 2019-09-20 00:24    [W:5.957 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site