Messages in this thread | | | Subject | Re: [PATCH v3 1/2] x86: Don't let pgprot_modify() change the page encryption bit | From | Dave Hansen <> | Date | Wed, 18 Sep 2019 10:57:40 -0700 |
| |
On 9/17/19 6:01 AM, Thomas Hellström (VMware) wrote: > diff --git a/arch/x86/include/asm/pgtable_types.h b/arch/x86/include/asm/pgtable_types.h > index b5e49e6bac63..8267dd426b15 100644 > --- a/arch/x86/include/asm/pgtable_types.h > +++ b/arch/x86/include/asm/pgtable_types.h > @@ -123,7 +123,7 @@ > */ > #define _PAGE_CHG_MASK (PTE_PFN_MASK | _PAGE_PCD | _PAGE_PWT | \ > _PAGE_SPECIAL | _PAGE_ACCESSED | _PAGE_DIRTY | \ > - _PAGE_SOFT_DIRTY | _PAGE_DEVMAP) > + _PAGE_SOFT_DIRTY | _PAGE_DEVMAP | _PAGE_ENC) > #define _HPAGE_CHG_MASK (_PAGE_CHG_MASK | _PAGE_PSE)
My only nit with what remains is that it expands the infestation of things that look like a simple macro but are not.
I'm debating whether we want to go fix that now, though.
| |