Messages in this thread | | | Date | Wed, 18 Sep 2019 10:39:37 -0400 (EDT) | From | Alan Stern <> | Subject | Re: [PATCH] usb-storage: SCSI glue: use pr_fmt and pr_err |
| |
On Wed, 18 Sep 2019, Matthias Maennich wrote:
> Follow common practice and retire printk(KERN_ERR ...) in favor of > pr_fmt and pr_err.
As long as you're changing this, why not change it to dev_err() instead? That would be a lot more useful.
> Cc: Alan Stern <stern@rowland.harvard.edu> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: usb-storage@lists.one-eyed-alien.net > Signed-off-by: Matthias Maennich <maennich@google.com> > --- > drivers/usb/storage/scsiglue.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/storage/scsiglue.c b/drivers/usb/storage/scsiglue.c > index 6737fab94959..0b6fa225b352 100644 > --- a/drivers/usb/storage/scsiglue.c > +++ b/drivers/usb/storage/scsiglue.c > @@ -28,6 +28,8 @@ > * status of a command. > */ > > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > + > #include <linux/blkdev.h> > #include <linux/dma-mapping.h> > #include <linux/module.h> > @@ -379,8 +381,7 @@ static int queuecommand_lck(struct scsi_cmnd *srb, > > /* check for state-transition errors */ > if (us->srb != NULL) { > - printk(KERN_ERR "usb-storage: Error in %s: us->srb = %p\n", > - __func__, us->srb); > + pr_err("Error in %s: us->srb = %p\n", __func__, us->srb); > return SCSI_MLQUEUE_HOST_BUSY; > }
dev_err(&us->pusb_intf->dev, "Error in ...
Alan Stern
| |