Messages in this thread | | | Date | Wed, 18 Sep 2019 16:19:31 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH] net/phy: fix DP83865 10 Mbps HDX loopback disable function |
| |
On Wed, Sep 18, 2019 at 05:03:40PM +0300, Peter Mamonov wrote: > According to the DP83865 datasheet "The 10 Mbps HDX loopback can be > disabled in the expanded memory register 0x1C0.1." The driver erroneously > used bit 0 instead of bit 1. > > Signed-off-by: Peter Mamonov <pmamonov@gmail.com> > --- > drivers/net/phy/national.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/phy/national.c b/drivers/net/phy/national.c > index 2addf1d3f619..4892e785dbf3 100644 > --- a/drivers/net/phy/national.c > +++ b/drivers/net/phy/national.c > @@ -110,11 +110,14 @@ static void ns_giga_speed_fallback(struct phy_device *phydev, int mode) > > static void ns_10_base_t_hdx_loopack(struct phy_device *phydev, int disable) > { > + u16 lb_dis = 1 << 1;
Hi Peter
Please use the BIT() macro.
> + > if (disable) > - ns_exp_write(phydev, 0x1c0, ns_exp_read(phydev, 0x1c0) | 1); > + ns_exp_write(phydev, 0x1c0, > + ns_exp_read(phydev, 0x1c0) | lb_dis); > else > ns_exp_write(phydev, 0x1c0, > - ns_exp_read(phydev, 0x1c0) & 0xfffe); > + ns_exp_read(phydev, 0x1c0) & ~lb_dis); > > pr_debug("10BASE-T HDX loopback %s\n", > (ns_exp_read(phydev, 0x1c0) & 0x0001) ? "off" : "on");
Isn't this also wrong?
Andrew
| |