Messages in this thread | | | From | Andy Shevchenko <> | Date | Wed, 18 Sep 2019 16:07:15 +0300 | Subject | Re: [PATCH v2 1/1] platform/x86/intel_cht_int33fe: Split code to USB TypeB and TypeC variants |
| |
On Tue, Sep 17, 2019 at 10:45 PM Yauhen Kharuzhy <jekhor@gmail.com> wrote: > > Existing intel_cht_int33fe ACPI pseudo-device driver assumes that > hardware has TypeC connector and register related devices described as > I2C connections in the _CRS resource. > > There is at least one hardware (Lenovo Yoga Book YB1-91L/F) with micro > USB B connector exists. It has INT33FE device in the DSDT table but > there are only two I2C connection described: PMIC and BQ27452 battery > fuel gauge. > > Splitting existing INT33FE driver allow to maintain code for USB type B > (AB) connector variant separately and make it simpler. > > Split driver to intel_cht_int33fe_common.c and > intel_cht_int33fe_{typeb,typec}.c. Compile all this source to one .ko > module to make user experience easier.
Before sending new version also check that you spell correctly "Type-C" everywhere (except variable / function names).
-- With Best Regards, Andy Shevchenko
| |