lkml.org 
[lkml]   [2019]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [alsa-devel] [RFC PATCH 8/9] soundwire: intel: remove platform devices and provide new interface
    On Tue, Sep 17, 2019 at 09:29:52AM -0500, Pierre-Louis Bossart wrote:
    > On 9/17/19 12:55 AM, Greg KH wrote:
    > > On Mon, Sep 16, 2019 at 04:23:41PM -0500, Pierre-Louis Bossart wrote:
    > > > +/**
    > > > + * sdw_intel_probe() - SoundWire Intel probe routine
    > > > + * @parent_handle: ACPI parent handle
    > > > + * @res: resource data
    > > > + *
    > > > + * This creates SoundWire Master and Slave devices below the controller.
    > > > + * All the information necessary is stored in the context, and the res
    > > > + * argument pointer can be freed after this step.
    > > > + */
    > > > +struct sdw_intel_ctx
    > > > +*sdw_intel_probe(struct sdw_intel_res *res)
    > > > +{
    > > > + return sdw_intel_probe_controller(res);
    > > > +}
    > > > +EXPORT_SYMBOL(sdw_intel_probe);
    > > > +
    > > > +/**
    > > > + * sdw_intel_startup() - SoundWire Intel startup
    > > > + * @ctx: SoundWire context allocated in the probe
    > > > + *
    > > > + */
    > > > +int sdw_intel_startup(struct sdw_intel_ctx *ctx)
    > > > +{
    > > > + return sdw_intel_startup_controller(ctx);
    > > > +}
    > > > +EXPORT_SYMBOL(sdw_intel_startup);
    > >
    > > Why are you exporting these functions if no one calls them?
    >
    > They are used in the next series, see '[RFC PATCH 04/12] ASoC: SOF: Intel:
    > add SoundWire configuration interface'

    That wasn't obvious :)

    Also, why not EXPORT_SYMBOL_GPL()? :)

    thanks,

    greg k-h

    \
     
     \ /
      Last update: 2019-09-18 14:07    [W:2.395 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site