Messages in this thread | | | Subject | Re: [PATCH] ionic: Remove unnecessary ternary operator in ionic_debugfs_add_ident | From | Shannon Nelson <> | Date | Tue, 17 Sep 2019 16:40:13 -0700 |
| |
On 9/17/19 4:26 PM, Nathan Chancellor wrote: > clang warns: > > ../drivers/net/ethernet/pensando/ionic/ionic_debugfs.c:60:37: warning: > expression result unused [-Wunused-value] > ionic, &identity_fops) ? 0 : -EOPNOTSUPP; > ^~~~~~~~~~~ > 1 warning generated. > > The return value of debugfs_create_file does not need to be checked [1] > and the function returns void so get rid of the ternary operator, it is > unnecessary. > > [1]: https://lore.kernel.org/linux-mm/20150815160730.GB25186@kroah.com/ > > Fixes: fbfb8031533c ("ionic: Add hardware init and device commands") > Link: https://github.com/ClangBuiltLinux/linux/issues/658 > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Acked-by: Shannon Nelson <snelson@pensando.io>
> --- > drivers/net/ethernet/pensando/ionic/ionic_debugfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c b/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c > index 7afc4a365b75..bc03cecf80cc 100644 > --- a/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c > +++ b/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c > @@ -57,7 +57,7 @@ DEFINE_SHOW_ATTRIBUTE(identity); > void ionic_debugfs_add_ident(struct ionic *ionic) > { > debugfs_create_file("identity", 0400, ionic->dentry, > - ionic, &identity_fops) ? 0 : -EOPNOTSUPP; > + ionic, &identity_fops); > } > > void ionic_debugfs_add_sizes(struct ionic *ionic)
| |