Messages in this thread | | | Date | Sat, 14 Sep 2019 14:04:41 +0100 | From | Jarkko Sakkinen <> | Subject | Re: [PATCH v4] KEYS: trusted: correctly initialize digests and fix locking issue |
| |
On Fri, Sep 13, 2019 at 08:51:36PM +0200, Roberto Sassu wrote: > Commit 0b6cf6b97b7e ("tpm: pass an array of tpm_extend_digest structures to > tpm_pcr_extend()") modifies tpm_pcr_extend() to accept a digest for each > PCR bank. After modification, tpm_pcr_extend() expects that digests are > passed in the same order as the algorithms set in chip->allocated_banks. > > This patch fixes two issues introduced in the last iterations of the patch > set: missing initialization of the TPM algorithm ID in the tpm_digest > structures passed to tpm_pcr_extend() by the trusted key module, and > unreleased locks in the TPM driver due to returning from tpm_pcr_extend() > without calling tpm_put_ops(). > > Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com> > Suggested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> > Reviewed-by: Jerry Snitselaar <jsnitsel@redhat.com> > Fixes: 0b6cf6b97b7e ("tpm: pass an array of tpm_extend_digest structures to tpm_pcr_extend()")
Reviewed-by: <jarkko.sakkinen@linux.intel.com>
I picked up this patch to my tree.
/Jarkko
| |