Messages in this thread | | | Subject | Re: Regression: commit c9712e333809 breaks xilinx_uartps | From | Michal Simek <> | Date | Fri, 13 Sep 2019 08:03:37 +0200 |
| |
On 12. 09. 19 18:38, Paul Thomas wrote: >>> --- >>> drivers/tty/serial/xilinx_uartps.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/drivers/tty/serial/xilinx_uartps.c >>> b/drivers/tty/serial/xilinx_uartps.c >>> index 9dcc4d855ddd..ece7f6caa994 100644 >>> --- a/drivers/tty/serial/xilinx_uartps.c >>> +++ b/drivers/tty/serial/xilinx_uartps.c >>> @@ -1565,6 +1565,8 @@ static int cdns_uart_probe(struct platform_device *pdev) >>> >>> cdns_uart_data->pclk = devm_clk_get(&pdev->dev, "pclk"); >>> if (PTR_ERR(cdns_uart_data->pclk) == -EPROBE_DEFER) { >>> + /* If we end up defering then set uartps_major back to 0 */ >>> + uartps_major = 0; >>> rc = PTR_ERR(cdns_uart_data->pclk); >>> goto err_out_unregister_driver; >>> } >>> >> >> I expect that this can be problematic for all failures in probe. >> What about this? > Makes sense, this worked for me. Although, I think the patch is > malformed by the email line lengths.
I just c&p. Let me send proper patch with description.
Thanks, Michal
| |