Messages in this thread | | | Subject | Re: [Ksummit-discuss] [PATCH v2 3/3] libnvdimm, MAINTAINERS: Maintainer Entry Profile | From | Joe Perches <> | Date | Wed, 11 Sep 2019 13:30:53 -0700 |
| |
On Wed, 2019-09-11 at 08:48 -0700, Dan Williams wrote: > Document the basic policies of the libnvdimm subsystem and provide a first > example of a Maintainer Entry Profile for others to duplicate and edit. [] > +Coding Style Addendum > +--------------------- > +libnvdimm expects multi-line statements to be double indented. I.e. > + > + if (x... > + && ...y) {
I don't find a good reason to do this.
> diff --git a/MAINTAINERS b/MAINTAINERS [] > @@ -9185,6 +9185,7 @@ M: Dan Williams <dan.j.williams@intel.com> > M: Vishal Verma <vishal.l.verma@intel.com> > M: Dave Jiang <dave.jiang@intel.com> > L: linux-nvdimm@lists.01.org > +P: Documentation/nvdimm/maintainer-entry-profile.rst
I also think the indirection to a separate file is not a good thing.
Separate styles for individual subsystems is not something I would want to encourage.
| |