lkml.org 
[lkml]   [2019]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: linux-next: Fixes tag needs some work in the pm tree
Date
On Wednesday, September 11, 2019 9:27:41 AM CEST Heikki Krogerus wrote:
> On Wed, Sep 11, 2019 at 12:33:06AM +1000, Stephen Rothwell wrote:
> > Hi all,
> >
> > In commit
> >
> > fd3f7275826f ("software node: Initialize the return value in software_node_find_by_name()")
> >
> > Fixes tag
> >
> > Fixes: 1666faedb567 ("software node: Add software_node_get_reference_args()")
> >
> > has these problem(s):
> >
> > - Subject does not match target commit subject
> > Just use
> > git log -1 --format='Fixes: %h ("%s")'
> >
> > Did you mean
> >
> > Fixes: 1666faedb567 ("software node: Add software_node_find_by_name()")
> >
> > or
> >
> > Fixes: b06184acf751 ("software node: Add software_node_get_reference_args()")
>
> Rafael, it seems you have rebased your branch.

No, I haven't.

Actually, the commit ID is correct, but the name isn't.

You'd have been unlikely to get a valid commit ID matching anything with
"software node" in the subject had it been rebased. :-)

> Do you want me to resend those fixes, or can you fix the tags in them
> yourself?

I fixed that tag up.

Thanks,
Rafael



\
 
 \ /
  Last update: 2019-09-11 19:18    [W:0.142 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site