Messages in this thread | | | From | Felipe Balbi <> | Subject | Re: [PATCH v3 1/2] PTP: introduce new versions of IOCTLs | Date | Wed, 11 Sep 2019 09:08:12 +0300 |
| |
Hi,
Richard Cochran <richardcochran@gmail.com> writes: > On Mon, Sep 09, 2019 at 10:59:39AM +0300, Felipe Balbi wrote: > >> case PTP_PEROUT_REQUEST: >> + case PTP_PEROUT_REQUEST2: > > ... > >> + if (((req.perout.flags & ~PTP_PEROUT_VALID_FLAGS) || >> + req.perout.rsv[0] || req.perout.rsv[1] || >> + req.perout.rsv[2] || req.perout.rsv[3]) && >> + cmd == PTP_PEROUT_REQUEST2) { >> + err = -EINVAL; >> + break; > > ... > >> +/* >> + * Bits of the ptp_perout_request.flags field: >> + */ >> +#define PTP_PEROUT_VALID_FLAGS (~0) > > I think you meant (0) here, or I am confused...
Argh. What a brain fart!
Sorry about that. I'll go fix that ASAP.
-- balbi [unhandled content-type:application/pgp-signature]
| |