lkml.org 
[lkml]   [2019]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] btrfs: fix Wmaybe-uninitialized warning
Hello, maintainers.

If you are available, please review this patch and share the feedback.

Thanks,
Austin Kim

2019년 9월 3일 (화) 오후 12:30, Austin Kim <austindh.kim@gmail.com>님이 작성:
>
> gcc throws warning message as below:
>
> ‘clone_src_i_size’ may be used uninitialized in this function
> [-Wmaybe-uninitialized]
> #define IS_ALIGNED(x, a) (((x) & ((typeof(x))(a) - 1)) == 0)
> ^
> fs/btrfs/send.c:5088:6: note: ‘clone_src_i_size’ was declared here
> u64 clone_src_i_size;
> ^
> The clone_src_i_size is only used as call-by-reference
> in a call to get_inode_info().
>
> Silence the warning by initializing clone_src_i_size to 0.
>
> Signed-off-by: Austin Kim <austindh.kim@gmail.com>
> ---
> fs/btrfs/send.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
> index f856d6c..197536b 100644
> --- a/fs/btrfs/send.c
> +++ b/fs/btrfs/send.c
> @@ -5085,7 +5085,7 @@ static int clone_range(struct send_ctx *sctx,
> struct btrfs_path *path;
> struct btrfs_key key;
> int ret;
> - u64 clone_src_i_size;
> + u64 clone_src_i_size = 0;
>
> /*
> * Prevent cloning from a zero offset with a length matching the sector
> --
> 2.6.2
>

\
 
 \ /
  Last update: 2019-09-10 18:40    [W:0.033 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site