Messages in this thread Patch in this message | | | Date | Tue, 10 Sep 2019 17:16:03 +0200 | From | Alexandre Belloni <> | Subject | Re: [PATCH 1/2] clk: at91: fix update bit maps on CFG_MOR write |
| |
On 09/09/2019 15:30:31+0000, Eugen.Hristev@microchip.com wrote: > From: Eugen Hristev <eugen.hristev@microchip.com> > > The regmap update bits call was not selecting the proper mask, considering > the bits which was updating. > Update the mask from call to also include OSCBYPASS. > Removed MOSCEN which was not updated. > > Fixes: 1bdf02326b71 ("clk: at91: make use of syscon/regmap internally") > Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com> Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> --- > drivers/clk/at91/clk-main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/at91/clk-main.c b/drivers/clk/at91/clk-main.c > index f607ee7..ebe9b99 100644 > --- a/drivers/clk/at91/clk-main.c > +++ b/drivers/clk/at91/clk-main.c > @@ -152,7 +152,7 @@ at91_clk_register_main_osc(struct regmap *regmap, > if (bypass) > regmap_update_bits(regmap, > AT91_CKGR_MOR, MOR_KEY_MASK | > - AT91_PMC_MOSCEN, > + AT91_PMC_OSCBYPASS, > AT91_PMC_OSCBYPASS | AT91_PMC_KEY); > > hw = &osc->hw; > -- > 2.7.4 >
-- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
| |