Messages in this thread | | | Subject | Re: [PATCH 3/3] arm64: alpine: select AL_POS | From | "Shenhar, Talel" <> | Date | Tue, 10 Sep 2019 09:17:11 +0300 |
| |
On 9/9/2019 6:08 PM, Arnd Bergmann wrote: > On Mon, Sep 9, 2019 at 3:59 PM Shenhar, Talel <talel@amazon.com> wrote: >> On 9/9/2019 4:45 PM, Arnd Bergmann wrote: >> >> Its not that something will get broken. its error event detector for POS >> events which allows seeing bad accesses to registers. >> >> What is the general rule of which configs to put under select and which >> under defconfig? >> >> I was thinking that "general" SoC support is good under select - those >> things that we always want. > I generally want as little as possible to be selected, basically only > things that are required for linking the kernel and booting it without > potentially destroying the hardware. > > In particular, I want most drivers to be enabled as loadable modules > if possible. When you have general-purpose distributions support > your platform, there is no need to have this module built-in while > running on a different chip, even if you always want to load the > module when it's running on yours. > >> And specific features, e.g. RAID support or features that supported only >> on specific HW shall go under defconfig. >> >> Similar, I see ARCH_LAYERSCAPE selecting EDAC_SUPPORT. > I think this was done to avoid a link failure. It's also possible that this > is a mistake and just did not get caught in review. > > Arnd
I see.
Will remove this from v2.
| |