lkml.org 
[lkml]   [2019]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 0/3] Remove __online_page_set_limits()
From
Date
On 10.09.19 14:56, Souptick Joarder wrote:
> On Mon, Sep 9, 2019 at 9:12 PM Kirill A. Shutemov <kirill@shutemov.name> wrote:
>>
>> On Sun, Sep 08, 2019 at 03:17:01AM +0530, Souptick Joarder wrote:
>>> __online_page_set_limits() is a dummy function and an extra call
>>> to this can be avoided.
>>>
>>> As both of the callers are now removed, __online_page_set_limits()
>>> can be removed permanently.
>>>
>>> Souptick Joarder (3):
>>> hv_ballon: Avoid calling dummy function __online_page_set_limits()
>>> xen/ballon: Avoid calling dummy function __online_page_set_limits()
>>> mm/memory_hotplug.c: Remove __online_page_set_limits()
>>>
>>> drivers/hv/hv_balloon.c | 1 -
>>> drivers/xen/balloon.c | 1 -
>>> include/linux/memory_hotplug.h | 1 -
>>> mm/memory_hotplug.c | 5 -----
>>> 4 files changed, 8 deletions(-)
>>
>> Do we really need 3 separate patches to remove 8 lines of code?
>
> I prefer to split into series of 3 which looks more clean. But I am ok
> with other option.
> Would you like to merge into single one ?
>

If you have to resend, you could squash them into one. If not, I think
this is okay ...

--

Thanks,

David / dhildenb

\
 
 \ /
  Last update: 2019-09-10 14:59    [W:0.041 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site