Messages in this thread | | | Date | Tue, 10 Sep 2019 11:11:42 +0200 | From | Joerg Roedel <> | Subject | Re: [PATCH] iommu/amd: Fix sparse warnings |
| |
On Sat, Sep 07, 2019 at 04:58:12PM +1000, Adam Zerella wrote: > There was some simple Sparse warnings related to making some > signatures static.
And unapplied both of your patches as they causes build failures:
arch/x86/events/amd/iommu.o: In function `perf_iommu_read': iommu.c:(.text+0xba): undefined reference to `amd_iommu_pc_get_reg' arch/x86/events/amd/iommu.o: In function `perf_iommu_start': iommu.c:(.text+0x2df): undefined reference to `amd_iommu_pc_set_reg' iommu.c:(.text+0x324): undefined reference to `amd_iommu_pc_set_reg' iommu.c:(.text+0x36b): undefined reference to `amd_iommu_pc_set_reg' iommu.c:(.text+0x3b0): undefined reference to `amd_iommu_pc_set_reg' iommu.c:(.text+0x424): undefined reference to `amd_iommu_pc_set_reg' arch/x86/events/amd/iommu.o:iommu.c:(.text+0x4e4): more undefined references to `amd_iommu_pc_set_reg' follow arch/x86/events/amd/iommu.o: In function `amd_iommu_pc_init': iommu.c:(.init.text+0xc): undefined reference to `amd_iommu_pc_supported' iommu.c:(.init.text+0x131): undefined reference to `get_amd_iommu' iommu.c:(.init.text+0x140): undefined reference to `amd_iommu_pc_get_max_banks' iommu.c:(.init.text+0x14f): undefined reference to `amd_iommu_pc_get_max_counters' drivers/char/agp/intel-gtt.o: In function `intel_gmch_probe': intel-gtt.c:(.text+0x135d): undefined reference to `intel_iommu_gfx_mapped' drivers/iommu/amd_iommu_init.o: In function `state_next': amd_iommu_init.c:(.init.text+0x1ace): undefined reference to `amd_iommu_ops' drivers/iommu/dmar.o: In function `dmar_parse_one_drhd': dmar.c:(.text+0x125c): undefined reference to `intel_iommu_ops' drivers/gpu/drm/i915/intel_device_info.o: In function `intel_device_info_runtime_init': intel_device_info.c:(.text+0xd89): undefined reference to `intel_iommu_gfx_mapped' drivers/gpu/drm/i915/gem/i915_gem_stolen.o: In function `i915_gem_init_stolen': i915_gem_stolen.c:(.text+0x33a): undefined reference to `intel_iommu_gfx_mapped' drivers/gpu/drm/i915/i915_gem_gtt.o: In function `i915_ggtt_probe_hw': i915_gem_gtt.c:(.text+0x4f61): undefined reference to `intel_iommu_gfx_mapped' i915_gem_gtt.c:(.text+0x5127): undefined reference to `intel_iommu_gfx_mapped' i915_gem_gtt.c:(.text+0x52d1): undefined reference to `intel_iommu_gfx_mapped' drivers/gpu/drm/i915/i915_gem_gtt.o:i915_gem_gtt.c:(.text+0x53b3): more undefined references to `intel_iommu_gfx_mapped' follow
Please compile-test your patches next time.
| |