lkml.org 
[lkml]   [2019]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 1/1] iommu/vt-d: Correctly check format of page table in debugfs
    From
    Date
    Hi Joerg,

    Just a friendly reminder. What do you think of this fix?

    Best regards,
    Lu Baolu

    On 7/20/19 10:01 AM, Lu Baolu wrote:
    > PASID support and enable bit in the context entry isn't the right
    > indicator for the type of tables (legacy or scalable mode). Check
    > the DMA_RTADDR_SMT bit in the root context pointer instead.
    >
    > Cc: Ashok Raj <ashok.raj@intel.com>
    > Cc: Jacob Pan <jacob.jun.pan@linux.intel.com>
    > Cc: Kevin Tian <kevin.tian@intel.com>
    > Cc: Sai Praneeth <sai.praneeth.prakhya@intel.com>
    > Fixes: dd5142ca5d24b ("iommu/vt-d: Add debugfs support to show scalable mode DMAR table internals")
    > Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
    > ---
    > drivers/iommu/intel-iommu-debugfs.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/iommu/intel-iommu-debugfs.c b/drivers/iommu/intel-iommu-debugfs.c
    > index 73a552914455..e31c3b416351 100644
    > --- a/drivers/iommu/intel-iommu-debugfs.c
    > +++ b/drivers/iommu/intel-iommu-debugfs.c
    > @@ -235,7 +235,7 @@ static void ctx_tbl_walk(struct seq_file *m, struct intel_iommu *iommu, u16 bus)
    > tbl_wlk.ctx_entry = context;
    > m->private = &tbl_wlk;
    >
    > - if (pasid_supported(iommu) && is_pasid_enabled(context)) {
    > + if (dmar_readq(iommu->reg + DMAR_RTADDR_REG) & DMA_RTADDR_SMT) {
    > pasid_dir_ptr = context->lo & VTD_PAGE_MASK;
    > pasid_dir_size = get_pasid_dir_size(context);
    > pasid_dir_walk(m, pasid_dir_ptr, pasid_dir_size);
    >

    \
     
     \ /
      Last update: 2019-08-09 07:39    [W:4.374 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site