lkml.org 
[lkml]   [2019]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v8 01/21] pinctrl: tegra: Fix write barrier placement in pmx_writel
    Date
    pmx_writel uses writel which inserts write barrier before the
    register write rather.

    This patch has fix to replace writel with writel_relaxed followed
    by a write barrier to ensure write operation before the barrier
    is completed for successful pinctrl change.

    Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
    ---
    drivers/pinctrl/tegra/pinctrl-tegra.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/pinctrl/tegra/pinctrl-tegra.c b/drivers/pinctrl/tegra/pinctrl-tegra.c
    index e3a237534281..982ee634b3b1 100644
    --- a/drivers/pinctrl/tegra/pinctrl-tegra.c
    +++ b/drivers/pinctrl/tegra/pinctrl-tegra.c
    @@ -32,7 +32,9 @@ static inline u32 pmx_readl(struct tegra_pmx *pmx, u32 bank, u32 reg)

    static inline void pmx_writel(struct tegra_pmx *pmx, u32 val, u32 bank, u32 reg)
    {
    - writel(val, pmx->regs[bank] + reg);
    + writel_relaxed(val, pmx->regs[bank] + reg);
    + /* make sure pinmux register write completed */
    + wmb();
    }

    static int tegra_pinctrl_get_groups_count(struct pinctrl_dev *pctldev)
    --
    2.7.4
    \
     
     \ /
      Last update: 2019-08-09 01:50    [W:4.338 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site