lkml.org 
[lkml]   [2019]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCHv5 06/37] alarmtimer: Provide get_timespec() callback
    On Mon, 29 Jul 2019, Dmitry Safonov wrote:
    > /**
    > @@ -869,8 +871,10 @@ static int __init alarmtimer_init(void)
    > /* Initialize alarm bases */
    > alarm_bases[ALARM_REALTIME].base_clockid = CLOCK_REALTIME;
    > alarm_bases[ALARM_REALTIME].get_ktime = &ktime_get_real;
    > + alarm_bases[ALARM_REALTIME].get_timespec = posix_get_timespec,

    That's just wrong:

    > /*
    > * Get monotonic time for posix timers
    > */
    > -static int posix_get_timespec(clockid_t which_clock, struct timespec64 *tp)
    > +int posix_get_timespec(clockid_t which_clock, struct timespec64 *tp)
    > {
    > ktime_get_ts64(tp);
    > return 0;

    Using a proper function name would have avoided this.

    \
     
     \ /
      Last update: 2019-08-07 08:04    [W:6.604 / U:0.252 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site