Messages in this thread | | | From | "Ardelean, Alexandru" <> | Subject | Re: [PATCH 04/16] net: phy: adin: add {write,read}_mmd hooks | Date | Tue, 6 Aug 2019 06:38:44 +0000 |
| |
On Mon, 2019-08-05 at 16:25 +0200, Andrew Lunn wrote: > [External] > > > diff --git a/drivers/net/phy/adin.c b/drivers/net/phy/adin.c > > index b75c723bda79..3dd9fe50f4c8 100644 > > --- a/drivers/net/phy/adin.c > > +++ b/drivers/net/phy/adin.c > > @@ -14,6 +14,9 @@ > > #define PHY_ID_ADIN1200 0x0283bc20 > > #define PHY_ID_ADIN1300 0x0283bc30 > > > > +#define ADIN1300_MII_EXT_REG_PTR 0x10 > > +#define ADIN1300_MII_EXT_REG_DATA 0x11 > > + > > #define ADIN1300_INT_MASK_REG 0x0018 > > Please be consistent with registers. Either use 4 digits, or 2 digits.
ack;
> > Andrew
| |