Messages in this thread | | | Subject | Re: [v2] net_sched: act_police: add 2 new attributes to support police 64bit rate and peakrate | From | "David Z. Dai" <> | Date | Fri, 30 Aug 2019 15:03:52 -0500 |
| |
On Fri, 2019-08-30 at 12:11 -0700, Cong Wang wrote: > On Fri, Aug 30, 2019 at 12:06 PM David Dai <zdai@linux.vnet.ibm.com> wrote: > > - if (p->peak_present) > > + if ((police->params->rate.rate_bytes_ps >= (1ULL << 32)) && > > + nla_put_u64_64bit(skb, TCA_POLICE_RATE64, > > + police->params->rate.rate_bytes_ps, > > + __TCA_POLICE_MAX)) > > I think the last parameter should be TCA_POLICE_PAD. Thanks for reviewing it! I have the impression that last parameter num value should be larger than the attribute num value in 2nd parameter (TC_POLICE_RATE64 in this case). This is the reason I changed the last parameter value to __TCA_POLICE_MAX after I moved the new attributes after TC_POLICE_PAD in pkt_cls.h header.
I rebuilt the kernel module act_police.ko by using TC_POLICE_PAD in the 4 parameter as before, I am able to set > 32bit rate and peakrate value in tc command. It also works properly.
If the rest of community thinks I should keep using TC_POLICE_PAD in the 4th parameter too, I can change it to TC_POLICE_PAD in the next version.
Thanks!
| |