Messages in this thread | | | Date | Fri, 30 Aug 2019 14:40:29 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH][V2] wimax/i2400m: remove debug containing bogus calculation of index |
| |
On Fri, Aug 30, 2019 at 10:07:11AM +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The subtraction of the two pointers is automatically scaled by the > size of the size of the object the pointers point to, so the division > by sizeof(*i2400m->barker) is incorrect. This has been broken since > day one of the driver and is only debug, so remove the debug completely. > > Also move && in condition to clean up a checkpatch warning. > > Addresses-Coverity: ("Extra sizeof expression") > Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards, dan carpenter
| |