Messages in this thread | | | Subject | Re: [PATCH v3 7/7] erofs: redundant assignment in __erofs_get_meta_page() | From | Chao Yu <> | Date | Fri, 30 Aug 2019 14:25:48 +0800 |
| |
On 2019/8/30 11:36, Gao Xiang wrote: > As Joe Perches suggested [1], > err = bio_add_page(bio, page, PAGE_SIZE, 0); > - if (unlikely(err != PAGE_SIZE)) { > + if (err != PAGE_SIZE) { > err = -EFAULT; > goto err_out; > } > > The initial assignment to err is odd as it's not > actually an error value -E<FOO> but a int size > from a unsigned int len. > > Here the return is either 0 or PAGE_SIZE. > > This would be more legible to me as: > > if (bio_add_page(bio, page, PAGE_SIZE, 0) != PAGE_SIZE) { > err = -EFAULT; > goto err_out; > } > > [1] https://lore.kernel.org/r/74c4784319b40deabfbaea92468f7e3ef44f1c96.camel@perches.com/ > Reported-by: Joe Perches <joe@perches.com> > Signed-off-by: Gao Xiang <gaoxiang25@huawei.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Thanks,
| |