| Subject | Re: [PATCH] printf: add support for printing symbolic error codes | From | Rasmus Villemoes <> | Date | Sat, 31 Aug 2019 00:03:58 +0200 |
| |
On 30/08/2019 23.53, Joe Perches wrote: > >> diff --git a/lib/vsprintf.c b/lib/vsprintf.c > [] >> @@ -2178,8 +2204,6 @@ char *pointer(const char *fmt, char *buf, char *end, void *ptr, >> return flags_string(buf, end, ptr, spec, fmt); >> case 'O': >> return kobject_string(buf, end, ptr, spec, fmt); >> - case 'x': >> - return pointer_string(buf, end, ptr, spec); >> } >> >> /* default is to _not_ leak addresses, hash before printing */ > > why remove this? >
The handling of %px is moved above the test for ptr being an ERR_PTR, so that %px, ptr continues to be (roughly) equivalent to %08lx, (long)ptr.
Rasmus
|