Messages in this thread | | | From | Linus Torvalds <> | Date | Thu, 29 Aug 2019 09:05:36 -0700 | Subject | Re: [RFC PATCH 0/5] make use of gcc 9's "asm inline()" |
| |
On Thu, Aug 29, 2019 at 1:32 AM Rasmus Villemoes <linux@rasmusvillemoes.dk> wrote: > > But since we #define the identifier inline to attach some attributes, > we have to use the alternate spelling __inline__ of that > keyword. Unfortunately, we also currently #define that one (to > inline), so we first have to get rid of all (mis)uses of > __inline__. Hence the huge diffstat.
Ugh. Not pretty, but I guess we're stuck with it.
However, it worries me a bit that you excluide the UAPI headers where we still use "__inline__", and now the semantics of that will change for the kernel (for some odd gcc versions).
I suspect we should just bite the bullet and you should do it to the uapi headers too. We already use "inline" in a lot of them, so it's not the case that we're using __inline__ because of some namespace issue, as far as I can tell.
One option might be to just use "__inline" for the asm_inline thing. We have way fewer of those. That would make the noise much less for this patch series.
Linus
| |