Messages in this thread | | | Subject | Re: [PATCH v2] powerpc/fadump: when fadump is supported register the fadump sysfs files. | From | Hari Bathini <> | Date | Thu, 29 Aug 2019 10:58:16 +0530 |
| |
On 28/08/19 10:57 PM, Michal Suchanek wrote: > Currently it is not possible to distinguish the case when fadump is > supported by firmware and disabled in kernel and completely unsupported > using the kernel sysfs interface. User can investigate the devicetree > but it is more reasonable to provide sysfs files in case we get some > fadumpv2 in the future. > > With this patch sysfs files are available whenever fadump is supported > by firmware. > > Signed-off-by: Michal Suchanek <msuchanek@suse.de> > ---
[...]
> - if (!fw_dump.fadump_supported) { > + if (!fw_dump.fadump_supported && fw_dump.fadump_enabled) { > printk(KERN_ERR "Firmware-assisted dump is not supported on" > " this hardware\n"); > - return 0; > }
The above hunk is redundant with similar message already logged during early boot in fadump_reserve_mem() function. I am not strongly against this though. So...
Acked-by: Hari Bathini <hbathini@linux.ibm.com>
| |