Messages in this thread | | | From | Nick Desaulniers <> | Date | Wed, 28 Aug 2019 15:44:59 -0700 | Subject | Re: [PATCH v2 00/14] treewide: prefer __section from compiler_attributes.h |
| |
On Tue, Aug 27, 2019 at 7:47 PM Joe Perches <joe@perches.com> wrote: > > On Tue, 2019-08-27 at 13:39 -0700, Nick Desaulniers wrote: > > GCC unescapes escaped string section names while Clang does not. Because > > __section uses the `#` stringification operator for the section name, it > > doesn't need to be escaped. > > > > This fixes an Oops observed in distro's that use systemd and not > > net.core.bpf_jit_enable=1, when their kernels are compiled with Clang. > > > > Instead, we should: > > 1. Prefer __section(.section_name_no_quotes). > > 2. Only use __attribute__((__section(".section"))) when creating the > > Please use __ before and after section > > i.e. __attribute__((__section__("<section_name>"))) > >
*explitive*!!! -- Thanks, ~Nick Desaulniers
| |