Messages in this thread Patch in this message | | | From | Jan Dakinevich <> | Subject | [PATCH 1/3] KVM: x86: fix wrong return code | Date | Tue, 27 Aug 2019 13:07:04 +0000 |
| |
x86_emulate_instruction(), the caller of x86_decode_insn(), expects that x86_decode_insn()'s returning value belongs to EMULATION_* name space. However, this function may return value from X86EMUL_* name space.
Although, the code behaves properly (because both X86EMUL_CONTINUE and EMULATION_OK are equal to 0) this change makes code more consistent and it is required for further fixes.
Cc: Denis Lunev <den@virtuozzo.com> Cc: Roman Kagan <rkagan@virtuozzo.com> Cc: Denis Plotnikov <dplotnikov@virtuozzo.com> Signed-off-by: Jan Dakinevich <jan.dakinevich@virtuozzo.com> --- arch/x86/kvm/emulate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c index 718f7d9..6170ddf 100644 --- a/arch/x86/kvm/emulate.c +++ b/arch/x86/kvm/emulate.c @@ -5144,7 +5144,7 @@ int x86_decode_insn(struct x86_emulate_ctxt *ctxt, void *insn, int insn_len) else { rc = __do_insn_fetch_bytes(ctxt, 1); if (rc != X86EMUL_CONTINUE) - return rc; + goto done; } switch (mode) { -- 2.1.4
| |