Messages in this thread | | | Date | Tue, 27 Aug 2019 14:55:04 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH 4/4] net: dsa: microchip: avoid hard-codded port count |
| |
On Tue, Aug 27, 2019 at 12:31:10PM +0300, Razvan Stefanescu wrote: > Use port_cnt value to disable interrupts on switch reset. > > Signed-off-by: Razvan Stefanescu <razvan.stefanescu@microchip.com> > --- > drivers/net/dsa/microchip/ksz9477.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/dsa/microchip/ksz9477.c b/drivers/net/dsa/microchip/ksz9477.c > index 187be42de5f1..54fc05595d48 100644 > --- a/drivers/net/dsa/microchip/ksz9477.c > +++ b/drivers/net/dsa/microchip/ksz9477.c > @@ -213,7 +213,7 @@ static int ksz9477_reset_switch(struct ksz_device *dev) > > /* disable interrupts */ > ksz_write32(dev, REG_SW_INT_MASK__4, SWITCH_INT_MASK); > - ksz_write32(dev, REG_SW_PORT_INT_MASK__4, 0x7F); > + ksz_write32(dev, REG_SW_PORT_INT_MASK__4, dev->port_cnt); > ksz_read32(dev, REG_SW_PORT_INT_STATUS__4, &data32);
Humm, is this correct? 0x7f suggests this is a bitmap for 7 ports. The name port_cnt suggests it is a count, e.g. 7 for 7 ports.
0x7f != 7.
Thanks Andrew
| |