Messages in this thread | | | From | Parav Pandit <> | Subject | RE: [PATCH 1/4] mdev: Introduce sha1 based mdev alias | Date | Tue, 27 Aug 2019 11:16:21 +0000 |
| |
> -----Original Message----- > From: Cornelia Huck <cohuck@redhat.com> > Sent: Tuesday, August 27, 2019 3:54 PM > To: Parav Pandit <parav@mellanox.com> > Cc: alex.williamson@redhat.com; Jiri Pirko <jiri@mellanox.com>; > kwankhede@nvidia.com; davem@davemloft.net; kvm@vger.kernel.org; linux- > kernel@vger.kernel.org; netdev@vger.kernel.org > Subject: Re: [PATCH 1/4] mdev: Introduce sha1 based mdev alias > > On Mon, 26 Aug 2019 15:41:16 -0500 > Parav Pandit <parav@mellanox.com> wrote: > > > > static int __init mdev_init(void) > > { > > + alias_hash = crypto_alloc_shash("sha1", 0, 0); > > + if (!alias_hash) > > + return -ENOMEM; > > + > > return mdev_bus_register(); > > Don't you need to call crypto_free_shash() if mdev_bus_register() fails? > Missed to answer this in previous reply. Yes, took care of it in v1. Mark Bloch also pointed it to me.
| |